Conversation
Restrict the buf-ci workflow's push trigger to top-level release tags (vX.Y.Z[-suffix]) and all branches. Submodule tags such as cmd/tableauc/vX.Y.Z (consumed by release.yml) no longer trigger buf-action, preventing them from being pushed to BSR as spurious tags.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 74.87% 74.87%
=======================================
Files 88 88
Lines 9384 9384
=======================================
Hits 7026 7026
Misses 1785 1785
Partials 573 573 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This repo tags releases at two levels:
vX.Y.Z(the library / proto module release).cmd/tableauc/vX.Y.Z(consumed byrelease.ymlto buildthe
tableaucbinary archives).The previous
buf-ci.ymlhad an unfilteredpush:trigger, so everypushed tag, including
cmd/tableauc/vX.Y.Z, ranbufbuild/buf-actionand ended up on BSR as a separate tag.
buf-actionitself has notag-name filter, so this had to be solved at the workflow trigger layer.
Fix
Use a tag whitelist on the
pushtrigger so only top-level releasetags reach
buf-action: