Fix Syslog Dismiss Problem#92
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an interaction between <syslog.h> macro definitions (e.g., LOG_DEBUG, LOG_INFO) and the tool’s compile-time log-level selection by converting the LOG=... Make variable into a numeric HLOG value in the build system, avoiding macro substitution at compile time.
Changes:
- Add a Makefile mapping from
LOG_{TRACE,DEBUG,INFO,WARN,ERROR,FATAL}to numeric levels0..5. - Pass the numeric level via
-DHLOG=$(HLOG_LEVEL)instead of-DHLOG=$(LOG). - Fail fast with a clear Makefile error if
LOGis not one of the supported values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in macro definitions in syslog.h override the output level definitions inside hvisor-tool.
his commit bypasses this issue by determining the values earlier in the Makefile.