Skip to content

[Mobile] SYST-707: Make it easy to set how large is the drawer on combobox mobile mode#413

Merged
adamnoto merged 3 commits into
mainfrom
mobile/make-it-easy-set-how-large-is-the-drawer
Jun 3, 2026
Merged

[Mobile] SYST-707: Make it easy to set how large is the drawer on combobox mobile mode#413
adamnoto merged 3 commits into
mainfrom
mobile/make-it-easy-set-how-large-is-the-drawer

Conversation

@alimnfl
Copy link
Copy Markdown
Contributor

@alimnfl alimnfl commented Jun 3, 2026

Description:
This pull request enhances the mobile prop of Combobox to support both a boolean or object value. Previously, the prop only accepted a boolean.

This approach provides a simple and scalable API, allowing future mobile-specific customizations to be introduced through a simple prop without adding additional configuration props.

<Combobox mobile={{ name: "A" }} />

The existing boolean usage remains fully supported:

<Combobox mobile />

It also ensures this approach works correctly, and introduces a drawerHeight inside of the mobile props.

Source:
[Mobile] SYST-707: Make it easy to set how large is the drawer on combobox mobile mode

Tick what you have done:
[x] I have double checked the functionality with the ticket in linear, or any other relevant discussion avenue
[x] I have created/updated any relevant test code
[x] I have tested it myself

@alimnfl alimnfl requested a review from adamnoto June 3, 2026 07:53
@alimnfl alimnfl self-assigned this Jun 3, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Jun 3, 2026

SYST-707

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Coneto Storybook preview deployed to: https://dev.files.systatum.com/coneto/9a220487

Copy link
Copy Markdown
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@adamnoto adamnoto merged commit 2c00f08 into main Jun 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants