Skip to content

[Mobile] SYST-691: Improve Dialog mobile look and feel#407

Merged
adamnoto merged 21 commits into
mainfrom
mobile/dialog-mobile-look-and-feel
Jun 4, 2026
Merged

[Mobile] SYST-691: Improve Dialog mobile look and feel#407
adamnoto merged 21 commits into
mainfrom
mobile/dialog-mobile-look-and-feel

Conversation

@alimnfl
Copy link
Copy Markdown
Contributor

@alimnfl alimnfl commented May 28, 2026

Description:
This pull request improves PaperDialog and Dialog components by preventing unintended text selection behavior inside both components. It also ensures that buttons inside Dialog do not display hover behavior on mobile interactions.

The button will make with separate task to this pull request

Source:
[Mobile] SYST-691: Improve Dialog mobile look and feel

Tick what you have done:
[x] I have double checked the functionality with the ticket in linear, or any other relevant discussion avenue
[x] I have created/updated any relevant test code
[x] I have tested it myself

@alimnfl alimnfl requested a review from adamnoto May 28, 2026 09:20
@alimnfl alimnfl self-assigned this May 28, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 28, 2026

SYST-691

@systatum systatum deleted a comment from github-actions Bot May 28, 2026
@systatum systatum deleted a comment from github-actions Bot May 28, 2026
@systatum systatum deleted a comment from github-actions Bot May 28, 2026
@systatum systatum deleted a comment from github-actions Bot May 29, 2026
@systatum systatum deleted a comment from github-actions Bot May 29, 2026
@systatum systatum deleted a comment from github-actions Bot May 29, 2026
@systatum systatum deleted a comment from github-actions Bot Jun 2, 2026
@systatum systatum deleted a comment from github-actions Bot Jun 2, 2026
@systatum systatum deleted a comment from github-actions Bot Jun 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Coneto Storybook preview deployed to: https://dev.files.systatum.com/coneto/9d2b5300

Copy link
Copy Markdown
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also ensures that buttons inside Dialog do not display hover behavior on mobile interactions.

This is not what the task wants tho:

And when we tap (or press/thumb-press) on the button, make it as if user is hovering (because on mobile we can't use hover, so the color indication should change differently, ie when pressed).

So the task description is exactly opposite to what the task says 🥲 . Basically, let's make those buttons work like mobile mode (we have mobile mode, just let's set those button mobile too when dialog mode is mobile)

@systatum systatum deleted a comment from github-actions Bot Jun 4, 2026
@systatum systatum deleted a comment from github-actions Bot Jun 4, 2026
@alimnfl
Copy link
Copy Markdown
Contributor Author

alimnfl commented Jun 4, 2026

It also ensures that buttons inside Dialog do not display hover behavior on mobile interactions.

This is not what the task wants tho:

And when we tap (or press/thumb-press) on the button, make it as if user is hovering (because on mobile we can't use hover, so the color indication should change differently, ie when pressed).

So the task description is exactly opposite to what the task says 🥲 . Basically, let's make those buttons work like mobile mode (we have mobile mode, just let's set those button mobile too when dialog mode is mobile)

done

@alimnfl alimnfl requested a review from adamnoto June 4, 2026 02:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Coneto Storybook preview deployed to: https://dev.files.systatum.com/coneto/9d2b5300

Copy link
Copy Markdown
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@adamnoto adamnoto merged commit 1d09ee1 into main Jun 4, 2026
1 check passed
@adamnoto adamnoto deleted the mobile/dialog-mobile-look-and-feel branch June 4, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants