fix: wrap ArrayData in ViewLayerData for SS6.1 compatibility#48
Open
tomstgeorge wants to merge 1 commit into
Open
fix: wrap ArrayData in ViewLayerData for SS6.1 compatibility#48tomstgeorge wants to merge 1 commit into
tomstgeorge wants to merge 1 commit into
Conversation
SSTemplateEngine::execute_template() changed its second parameter from ModelData to ViewLayerData in SilverStripe 6.1. Passing ArrayData directly caused a TypeError during dev/build when generating static error pages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSTemplateEngine requires ViewLayerData wrapping for ArrayData in SS6.1.