[Demo] Fix streamed recipe/chat SSE session handling#2302
Merged
Conversation
carsonbot
added
Bug
chr-hertel
force-pushed
the
fix-demo-sse-streaming
branch
from
b54b8d1 to
e6d2049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
recipeandstreamdemos use Server-Sent Events, and the SSE endpoints broke after the session-handling change in 3bfb360: the framework saved the real session while the streamed body was already sending output ("Failed to start the session because headers have already been sent").Restores the session-swap approach (thanks @valtzu) so the framework saves a throwaway session on
kernel.response, while the real session is only used inside the streamed callback.The related empty-message guard (skip the model call on reconnecting/stale SSE connections) is handled separately in #2304, which introduces the
MessageBaghelper it relies on.