[Demo] Fix streamed recipe/chat SSE session handling and empty input#2301
Closed
chr-hertel wants to merge 1 commit into
Closed
[Demo] Fix streamed recipe/chat SSE session handling and empty input#2301chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
carsonbot
added
Bug
Member
Author
|
Splitting into two focused PRs: a demo bug-fix for #2299 (session handling + empty-message guard) and a separate OpenAI Responses bridge hardening (with its own CHANGELOG entry). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the session-swap in the
recipe/streamSSEstreamContent()handlers (per @valtzu in #2299) to fix the "Failed to start the session because headers have already been sent" error, and guardsgetRecipeStream()/getAssistantResponse()against being called with no pending user message (reconnecting/stale SSE connections). Also hardens the OpenAI ResponsesMessageBagNormalizerto throw a clearInvalidArgumentExceptionwhen a request would be sent with emptyinputand noprevious_response_id/prompt/conversation_id, instead of an opaque provider 400.