[Platform] Fix #2274: Preserve cache and reasoning tokens in Generic completions usage#2275
Open
ineersa wants to merge 1 commit into
Open
[Platform] Fix #2274: Preserve cache and reasoning tokens in Generic completions usage#2275ineersa wants to merge 1 commit into
ineersa wants to merge 1 commit into
Conversation
carsonbot
added
Bug
chr-hertel
requested changes
Jul 9, 2026
|
|
||
| $this->assertSame(40, $tokenUsage->getCacheReadTokens()); | ||
| $this->assertSame(10, $tokenUsage->getCacheCreationTokens()); | ||
| $this->assertSame(40, $tokenUsage->getCachedTokens()); |
Member
There was a problem hiding this comment.
this should be 50 from my understanding: it basically sums up all tokens where cache could be used - no matter if read or create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic/OpenAI-compatible completions usage conversion now preserves provider-reported cache and reasoning token details.
The extractor now handles common usage shapes such as:
prompt_tokens_details.cached_tokensinput_tokens_details.cached_tokensprompt_cache_hit_tokensnum_cached_tokenscached_tokenscache_read_tokenscache_read_input_tokenscache_creation_tokenscache_creation_input_tokenscompletion_tokens_details.reasoning_tokensoutput_tokens_details.reasoning_tokensThis keeps existing prompt/completion/total token behavior unchanged while exposing available cache-read/cache-creation/cached/reasoning token data when providers include it.