increase coverage of Toolbox#2258
Open
makomweb wants to merge 4 commits into
Open
Conversation
makomweb
changed the title
chr-hertel
reviewed
Jul 11, 2026
Comment on lines
+41
to
+42
| } catch (ToolExecutionException $e) { | ||
| return new ToolResult($e->getToolCall(), $e->getToolCallResult()); |
Member
There was a problem hiding this comment.
this is a duplicate of line 43+44 since ToolExecutionException implements the ToolExecutionExceptionInterface
chr-hertel
reviewed
Jul 11, 2026
Comment on lines
+45
to
+49
| } catch (ToolNotFoundException $e) { | ||
| $names = array_map(static fn (Tool $metadata) => $metadata->getName(), $this->getTools()); | ||
|
|
||
| return new ToolResult( | ||
| $toolCall, | ||
| $e->getToolCall() ?? $toolCall, |
chr-hertel
requested changes
Jul 11, 2026
chr-hertel
left a comment
chr-hertel
left a comment
Member
There was a problem hiding this comment.
Hey Martin, thanks for working on the test coverage here 👍
just have some questions about the changes in the prod code
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to increase coverage of
Toolboxcode to 100%.Only change in non-test code was in
FaultTolerantToolboxto use the exceptionsgetToolCallmethod for full coverage. Side-note: Noticing this brought me to the idea to simplify the exception hierarchy of theToolbox(see #2257 for details).Before
After