[Platform][Albert] Align bridge base_url convention with Generic bridge#2243
Open
jvancoillie wants to merge 1 commit into
Open
[Platform][Albert] Align bridge base_url convention with Generic bridge#2243jvancoillie wants to merge 1 commit into
base_url convention with Generic bridge#2243jvancoillie wants to merge 1 commit into
Conversation
carsonbot
added
Platform
OskarStark
reviewed
Jun 26, 2026
OskarStark
reviewed
Jul 1, 2026
OskarStark
changed the title
base_url convention with Generic bridge
Contributor
|
Please check the failing CI step, thanks |
jvancoillie
force-pushed
the
fix/albert-base-url-convention
branch
2 times, most recently
from
e7b559d to
ef05ee8
Compare
The Albert bridge was requiring the API version in the base URL (e.g. https://example.com/v1) and overriding completionsPath/embeddingsPath to compensate, while Generic and all other bridges expect a bare base URL and include the version in the path (/v1/chat/completions). Drop the version validation and the path overrides so Albert delegates entirely to Generic defaults, aligning both conventions.
jvancoillie
force-pushed
the
fix/albert-base-url-convention
branch
from
1d79e17 to
c2d3ded
Compare
Contributor
Author
|
Email fixed, the remaining Resampler.php failure is unrelated to my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Albert bridge was requiring the API version in the base URL (e.g. https://example.com/v1) and overriding completionsPath/embeddingsPath to compensate, while Generic and all other bridges expect a bare base URL and include the version in the path (/v1/chat/completions).
Drop the version validation and the path overrides so Albert delegates entirely to Generic defaults, aligning both conventions.