[Store][Elasticsearch] Introduce a StoreFactory#2199
Open
Guikingone wants to merge 1 commit into
Open
Conversation
Guikingone
force-pushed
the
feature/store-factory-elasticsearch
branch
from
208876c to
c95110d
Compare
The `Store` constructor now expects a pre-scoped `HttpClientInterface`; endpoint scoping is performed by `StoreFactory::create()` via `ScopingHttpClient::forBaseUri()`. The `AiBundle` wiring switches to the factory.
Guikingone
force-pushed
the
feature/store-factory-elasticsearch
branch
from
c95110d to
6d44a94
Compare
carsonbot
added
Feature
Contributor
Author
|
@OskarStark @chr-hertel Do we have an estimated release date for PS: I have a few PRs using the same approach as this one on my local fork and wanted to know if we have a specific deadline. |
OskarStark
approved these changes
Jun 20, 2026
Member
|
@Guikingone i think i'm saying "in the next four weeks" since march now - doesn't help i guess, sorry 😆 edit: so, in the next four weeks :) |
chr-hertel
requested changes
Jun 21, 2026
Member
There was a problem hiding this comment.
should be reduced to BC breaks only, and for 0.11
Contributor
Author
|
@chr-hertel Well, now I know that I have one month to push as much PR as possible if I want them to be merged in i'll push all the PR that I have locally and update the existing ones, thanks for the update 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Storeconstructor now expects a pre-scopedHttpClientInterface; endpoint scoping is performed byStoreFactory::create()viaScopingHttpClient::forBaseUri(). TheAiBundlewiring switches to the factory.