fix: make catapult-docs-cli serialization generator work for NEM schemas#1168
Merged
segfaultxavi merged 3 commits intoMay 27, 2026
Merged
Conversation
Contributor
Author
|
cc/ @segfaultxavi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues prevented
serializationfrom producing usable output for the NEM catbuffer schemas:condition_valuecan be anintin NEM schemas. The previous string concatenation (v['condition'] + ' ' + ...) raisedTypeError: can only concatenate str (not "int") to str. Switched to.format()so any printable value works.schemalink hardcodedschemas/symbol. Changed it to be flexible to accept eithersymbolornem.<dl markdown><dt><code>ser:Name</code></dt><dd>...</dd></dl>block so the type name is shown as a title above the description and so each type becomes aser:glossary.