Add CSRF protection for picker model switching#35
Closed
ChengShiLiu16 wants to merge 1 commit into
Closed
Conversation
2 tasks
Collaborator
|
Integrated in #36 (CSRF token protection for |
Collaborator
|
Closing as superseded — this work was integrated and merged in #36. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a per-process picker token for the state-changing
/api/switchendpoint.The picker page embeds the token and sends it via
X-Codex-Shim-Picker-Tokenwhen switching models. Requests without the token, or with an invalid token, are rejected with 403.Why
The existing Host-header allowlist protects against DNS rebinding, but
/api/switchis a local control-plane write endpoint: it rewrites~/.codex/config.tomland can optionally restart Codex Desktop. Requiring a picker token prevents third-party pages from triggering model switches just because the loopback server is reachable.Tests
python3 -m compileall codex_shim/ -qpython3 -m py_compile tests/test_server.py tests/test_router_integration.pyuv run --isolated --python 3.11 --with aiohttp --with pytest --with pytest-asyncio python -m pytest tests/test_server.py tests/test_router_integration.py tests/test_hostguard.py -quv run --isolated --python 3.11 --with aiohttp --with pytest --with pytest-asyncio python -m pytest tests/ -qgit diff --check