189 resstock ev eda - #192
Draft
lmgittoes wants to merge 28 commits into
Draft
Conversation
Updated bsf to get hourly loads for 2025
Add gated miles/kWh calculations for 2024/2025 ResStock, compare NREL quota sampling vs Bernoulli adoption, and plot conditional vs categorical P(EV) by housing segment. Co-authored-by: Cursor <cursoragent@cursor.com>
alxsmith
reviewed
Jun 23, 2026
| hours_base: pl.DataFrame, | ||
| *, | ||
| kwh_per_mile: float, | ||
| ev_adoption_rate: float, |
Contributor
There was a problem hiding this comment.
is this really a float or is it a bool? I would expect it to be 0 or 1 if not i misunderstand this parameter
As a general comment please expand the docstrings of the functions you added to include arg definitions and what the function returns. here is a template. you dont always need the raises or example but args and returns are very helpful
def function_template(param1: int, param2: str = "default") -> bool:
"""A concise one-line summary of what the function does.
A longer description explaining the behavior, logic, side effects,
and any necessary architectural context for the function.
Args:
param1 (int): Description of the first parameter.
param2 (str, optional): Description of the second parameter.
Defaults to "default".
Returns:
bool: Description of the expected return value.
Raises:
ValueError: Description of when and why this error is raised.
Examples:
>>> function_template(10, "test")
True
"""
Collaborator
Author
There was a problem hiding this comment.
I haven't incorporated who has been an assigned an EV yet into ev_demand.py (that all still lives in the notebook dev/ev_adoption.ipynb) so right now ev_adoption_rate just scales the amount of discharge. But yes that will move to a boolean 0 or 1 once I incorporate the EV assignments
alxsmith
reviewed
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to ev_demand.py:
Current assumptions: