Update gst123.cc#25
Open
zhashuyu wants to merge 1 commit into
Open
Conversation
feat: decode filename from uri to normal string
(文件名由URL格式改为终端识别的字符)
from: Playing file:///home/boomer/A_DRIVER/Music-need-sync/%E9%9F%A9%E9%9B%AA/%E9%9F%A9%E9%9B%AA-%E6%83%B3%E8%B5%B7.mp3
to: Playing file:///home/boomer/A_DRIVER/Music-need-sync/韩雪/韩雪-想起.mp3
Owner
|
I have reworked your code to match gst123 coding style and committed it as 11c52fe - please test and let me know if everything works as expected for you. I didn't understand why I should specialcase "+" occuring in the URI, so I currently don't do that, as a filename on disk could contain a + sign, and I should be able to copypaste the filename output from gst123 and be able to play the file. |
Owner
|
Btw, the common case is probably that we are playing back some file that is stored locally (file:///...), for this case it probably makes sense to just display the filename without any prefix, I've done this now like this: 4846586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: decode filename from uri to normal string
(文件名由URL格式改为终端识别的字符)
from: Playing file:///home/boomer/A_DRIVER/Music-need-sync/%E9%9F%A9%E9%9B%AA/%E9%9F%A9%E9%9B%AA-%E6%83%B3%E8%B5%B7.mp3
to: Playing file:///home/boomer/A_DRIVER/Music-need-sync/韩雪/韩雪-想起.mp3