Skip to content

Update gst123.cc#25

Open
zhashuyu wants to merge 1 commit into
swesterfeld:masterfrom
zhashuyu:master
Open

Update gst123.cc#25
zhashuyu wants to merge 1 commit into
swesterfeld:masterfrom
zhashuyu:master

Conversation

@zhashuyu

@zhashuyu zhashuyu commented Apr 2, 2022

Copy link
Copy Markdown

feat: decode filename from uri to normal string
(文件名由URL格式改为终端识别的字符)
from: Playing file:///home/boomer/A_DRIVER/Music-need-sync/%E9%9F%A9%E9%9B%AA/%E9%9F%A9%E9%9B%AA-%E6%83%B3%E8%B5%B7.mp3
to: Playing file:///home/boomer/A_DRIVER/Music-need-sync/韩雪/韩雪-想起.mp3

feat: decode filename from uri to normal string
    (文件名由URL格式改为终端识别的字符)
from: Playing file:///home/boomer/A_DRIVER/Music-need-sync/%E9%9F%A9%E9%9B%AA/%E9%9F%A9%E9%9B%AA-%E6%83%B3%E8%B5%B7.mp3
to:   Playing file:///home/boomer/A_DRIVER/Music-need-sync/韩雪/韩雪-想起.mp3
@swesterfeld

Copy link
Copy Markdown
Owner

I have reworked your code to match gst123 coding style and committed it as 11c52fe - please test and let me know if everything works as expected for you.

I didn't understand why I should specialcase "+" occuring in the URI, so I currently don't do that, as a filename on disk could contain a + sign, and I should be able to copypaste the filename output from gst123 and be able to play the file.

@swesterfeld

Copy link
Copy Markdown
Owner

Btw, the common case is probably that we are playing back some file that is stored locally (file:///...), for this case it probably makes sense to just display the filename without any prefix, I've done this now like this: 4846586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants