This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Removes invalid render key option.#10
Open
amykhailova wants to merge 1 commit into
Open
Conversation
sbrindle
suggested changes
Sep 2, 2019
| foreach (Element::children($variables) as $key) { | ||
| $vars = $variables; | ||
| // Remove all not valid render keys. | ||
| foreach ($vars as $key => $var) { |
There was a problem hiding this comment.
I'm disagree with your modifications. The drupal good practice is to use "Element::children". But the implementation in the loop is not correct.
Author
There was a problem hiding this comment.
It's ok to disagree :). However without it invalid render keys were there and the module wasn't working, returning a fatal error. With what I did the module works and doesn't return any errors. There are many different ways of accomplishing tasks in web and it's not necessarily wrong to do things differently. It's not the foreach loop that matters in this case it's what's happening inside it. Notice how I prepare the variables and only then use Element::children. The foreach I used just cleans up the array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.