Fix vitest startup: align vite 8.1.2 + rolldown 1.1.3#21
Merged
Conversation
The locked rolldown 1.1.2 did not export viteWasmFallbackPlugin, which
vite 8.1.x imports from rolldown/experimental — breaking vitest at startup
("does not provide an export named 'viteWasmFallbackPlugin'"). Bumping vite
to 8.1.2 and pinning rolldown to 1.1.3 (which adds the export) restores it.
All 514 tests pass locally.
yarn install --frozen-lockfile rejected Node 20 against the package's
"engines": { "node": ">=24.0.0" }, failing the gate before tests ran.
Difftron — delta coverageCoverage Analysis ReportSummary
Modified Files
File Details
|
eslint-plugin-import@2.x crashes on ESLint 10 (import/order calls the removed sourceCode.getTokenOrCommentAfter), which failed the Buildkite lint step. The maintained fork eslint-plugin-import-x@4 supports ESLint 10; registered under the same `import` plugin key so all import/* rule names are unchanged. Also adds the URL global and applies the formatting/import-order fixes the crash had masked. Lint clean, all 514 tests pass.
swantron
force-pushed
the
fix-vite-rolldown
branch
from
800ab48 to
123a432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tronswan's vitest was failing at startup with
SyntaxError: The requested module 'rolldown/experimental' does not provide an export named 'viteWasmFallbackPlugin'— the locked rolldown 1.1.2 lacked that export. Bumps vite to 8.1.2 and pins rolldown 1.1.3. All 514 tests pass locally.