Remove dependency on typing-inspect#179
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 94.21% 94.07% -0.14%
==========================================
Files 4 4
Lines 760 759 -1
==========================================
- Hits 716 714 -2
- Misses 44 45 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martinjm97
left a comment
martinjm97
left a comment
There was a problem hiding this comment.
Looks excellent overall. Will take a more careful look soon. Thank you!
| """Same as typing_inspect.get_args but fixes Python 3.10 union types.""" | ||
| if isinstance(tp, UnionType): | ||
| return tp.__args__ | ||
| def is_literal_type(tp: Any) -> bool: |
There was a problem hiding this comment.
I think that it's worth adding a test for this change (if that indeed is what codecov has an issue with).
martinjm97
left a comment
martinjm97
left a comment
There was a problem hiding this comment.
Hi @gvalkov,
Thank you for contributing to Tap! It is now a little leaner and a little cleaner.
--JK
|
Happy to help :) Removing the tests from |
3 participants
Hello,
This project is using a tiny part of
typing-inspect. Most of what seems to be needed has already been implemented in Python 3.10. Not thattyping-inspectand its two transitive dependencies (mypy-extensions,typing-extensions) are bad, but less dependencies always gives more peace of mind, imho.Kind regards,
Georgi