Skip to content

Allow kwargs throughput when using tapify and TapIgnore#178

Merged
martinjm97 merged 15 commits into
swansonk14:mainfrom
Daraan:tap-ignore-kwargs-pass-through
Mar 28, 2026
Merged

Allow kwargs throughput when using tapify and TapIgnore#178
martinjm97 merged 15 commits into
swansonk14:mainfrom
Daraan:tap-ignore-kwargs-pass-through

Conversation

@Daraan

@Daraan Daraan commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Fixes: #177 + dataclasses + pydantic cases

Requires: #176

I've build this on the more convenient helper functions of #176. So that would be needed first (or doing some extractions which are more work)^^

@codecov-commenter

codecov-commenter commented Dec 30, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.46%. Comparing base (9379872) to head (3dc2945).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   94.21%   94.46%   +0.25%     
==========================================
  Files           4        4              
  Lines         760      795      +35     
==========================================
+ Hits          716      751      +35     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Daraan

Daraan commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

I'll resolve the conflicts when #176 is in, likely needs just a rebase - or in case #176 needs more time I'll look at this with some more time at hand.

@martinjm97 martinjm97 marked this pull request as ready for review March 28, 2026 20:21
@martinjm97 martinjm97 merged commit 9d1053c into swansonk14:main Mar 28, 2026
17 checks passed
@martinjm97

Copy link
Copy Markdown
Collaborator

Thank you again for all the amazing PRs! 🎊

--JK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tapify with TapIgnore should successfully thread through passed func_kwargs

3 participants