Fix deadlock between auto-pause and action execution#122
Open
BhekananiCele wants to merge 1 commit into
Open
Conversation
The lock-splitting change (splitting _lock into _actionsLock and _pauseLock) introduced a lock-ordering deadlock when AutoPause is enabled. _autoPauseTimer_Elapsed held _pauseLock and called Stop() which acquires _actionsLock, while PerformActions held _actionsLock and called StopAutoPauseTimer() which acquires _pauseLock. Move the Stop() call outside the _pauseLock in _autoPauseTimer_Elapsed to break the circular dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lock-splitting change (splitting _lock into _actionsLock and _pauseLock) introduced a lock-ordering deadlock when AutoPause is enabled. _autoPauseTimer_Elapsed held _pauseLock and called Stop() which acquires _actionsLock, while PerformActions held _actionsLock and called StopAutoPauseTimer() which acquires _pauseLock.
Move the Stop() call outside the _pauseLock in _autoPauseTimer_Elapsed to break the circular dependency.