fix(site): correct what the homepage claims and unify the radius scale - #73
Merged
Conversation
The rule contract panel was transcribed by hand. Under the heading "Read the bar before you adopt it", it gave R-CI-01's Check as "The workflow declares both trigger paths." The real Check turns on a pull_request trigger carrying no branches: filter, and says outright that a configuration carrying one fails. So the panel told a repository with branches: [main] that it passed, and the one element on the page offering verification was the one element nothing verified. The workflow trace card carried the same defect against R-SEC-01, dropping the composite actions the rule also covers. Both panels now read their fields from the parsed standard, including the fixing skill and forge scope that happened to be right. leadClause quotes the first sentence of a Check where a panel is too small to hold the whole clause, which is the only abridgement that cannot say something the standard does not, and each panel links to the full text. tests/homepage-claims.test.ts holds the sources to deriving what they quote, rather than to matching a string that would need updating with the rule.
Eleven border-radius values ran across 24 declarations, most of them a fraction of a pixel apart: a control at 5.6px beside one at 6px, a panel at 8px beside one at 8.8px. Nothing documented a reason for any gap and no two of the near-identical pairs ever appeared together, so the spread was drift. Four tokens replace them, named for the roles they serve: indicator, control, panel, and faceplate. Starlight, Expressive Code, and Pagefind round four more things from their own component styles at 4px and 3.2px, and each now takes the step its role names. DESIGN.md records the scale and the rule that governs adding to it. Semantics on the maintenance map: the example route's statement was an h2, so a SHA-pinning rule was the second heading on the site, ahead of every section. It is a paragraph now and the route is labelled by its own head. FaIcon serialized the literal string aria-label="undefined" onto every icon the site draws. A screen reader heard "Scanning now." for an activity nobody had started on a repository nobody had supplied. The lit bay's border measured 2.66:1 in light mode against WCAG 1.4.11's 3:1 for state, and now takes the same green three steps down at 5.43:1. The oss-audit rail named itself and never said what it produces, and both its captions were hidden below 34rem. The whole strip is the link now and carries the definition. The map's body no longer reserves 35rem of height it did not always fill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pull_requesttrigger carrying nobranches:filter, and says outright that a configuration carrying one fails. So under the heading "Read the bar before you adopt it", the page told a repository withbranches: [main]that it passed. Both quoting panels now read every field from the parsed standard, including the fixing skill and forge scope that happened to be right, and each links to the full clause.tests/homepage-claims.test.tsnow fails when either panel goes back to writing a rule field out by hand.border-radiusvalues ran across 24 declarations, most of them a fraction of a pixel apart: a control at 5.6px beside one at 6px, a panel at 8px beside one at 8.8px. Four tokens replace them, named for the roles they serve: indicator, control, panel, and faceplate. Starlight, Expressive Code, and Pagefind round four more things from their own component styles at 4px and 3.2px, and each now takes the step its role names.h2, so a SHA-pinning rule was the second heading on the site ahead of every section, rendered at 11.5px. Every icon the site draws carried the literal stringaria-label="undefined". A screen reader heard "Scanning now." for an activity nobody had started on a repository nobody had supplied. The lit bay's border measured 2.66:1 in light mode against WCAG 1.4.11's 3:1 for state.oss-auditrail named itself and never said what it produces, and both of its captions were hidden below 34rem, so the definition a reader needed sat a thousand pixels down the page. The whole strip is the link now and carries the definition. The map's body also stops reserving 35rem of height it did not always fill.Why this way
panelis 8px rather than the 10px DESIGN.md declared, because ten declarations already sat at 8px against two at 10.4px. The faceplate step survives the reduction because it holds a nesting a reader can see: the map rounds looser than the panels inside it, which is what makes it read as the container. Circles stay at 50% and the mobile bay stays square, because neither is a radius on this scale.Verification
bun test322 pass,bun run validate0 errors and 0 warnings,check-drift.shsilent,check-ecosystems.mjs11 ecosystems across 7 skills,astro build114 pages.index.mdx. It failed and printedCheck: The workflow declares both trigger paths., then passed again once reverted.#23b653on the white panel is 2.66:1, and#147a35on the same panel is 5.43:1.Known gaps
rgba(0, 0, 0, 0.28)andrgba(0, 0, 0, 0.35)stay legitimate and undocumented. That is the same gap the radius scale had, and it is the obvious next reconciliation.--kit-signal-lift, so the primary button hovers lighter there rather than deepening. That is unchanged behavior rather than something this branch decided, and whether light mode should deepen instead is open.support-linesrows are facts with no link target. Both need an information architecture decision rather than a fix.