Skip to content

feat: extend shadow DOM image replacements to include style.backgroundImage selectors #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svrnm merged 2 commits into from
Mar 17, 2026
Merged

feat: extend shadow DOM image replacements to include style.backgroundImage selectors #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e1f32
Initial plan
Copilot Mar 17, 2026
eebeb2c
feat: add style.backgroundImage support to shadow DOM image replacements
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/models/Monkey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,7 @@ class Monkey {
const ownerDocument = root.ownerDocument || root

if (ownerDocument && typeof ownerDocument.createTreeWalker === 'function') {
const walker = ownerDocument.createTreeWalker(
root,
NodeFilter.SHOW_ELEMENT,
null,
false
)
const walker = ownerDocument.createTreeWalker(root, NodeFilter.SHOW_ELEMENT, null, false)

let current = walker.currentNode
while (current) {
Expand All @@ -345,7 +340,9 @@ class Monkey {
// Guard against invalid roots that do not support querySelectorAll
if (!root || typeof root.querySelectorAll !== 'function') {
if (logger && typeof logger.warn === 'function') {
logger.warn('Monkey._collectOpenShadowRoots: root does not support querySelectorAll; skipping shadow root collection.')
logger.warn(
'Monkey._collectOpenShadowRoots: root does not support querySelectorAll; skipping shadow root collection.'
)
}
return shadowRoots
}
Expand All @@ -354,7 +351,10 @@ class Monkey {
elements = root.querySelectorAll('*')
} catch (e) {
if (logger && typeof logger.warn === 'function') {
logger.warn('Monkey._collectOpenShadowRoots: error while querying elements from root; skipping shadow root collection.', e)
logger.warn(
'Monkey._collectOpenShadowRoots: error while querying elements from root; skipping shadow root collection.',
e
)
}
return shadowRoots
}
Expand Down Expand Up @@ -396,6 +396,20 @@ class Monkey {
shadowRoot
)
sum.image += this._applyOnXpathGroup(configuration, './/img', 'image', 'src', shadowRoot)
sum.image += this._applyOnXpathGroup(
configuration,
'.//div[contains(@ad-test-id, "dash-image-widget-renderer")]',
'image',
'style.backgroundImage',
shadowRoot
)
sum.image += this._applyOnXpathGroup(
configuration,
'.//dash-kit-image-widget2/div/ui-kit-card-v1/div/div/div',
'image',
'style.backgroundImage',
shadowRoot
)
}
}

Expand Down
Loading