fix: set correct parent for lazily created derived inside SvelteDate#18509
Open
JaiWey wants to merge 2 commits into
Open
fix: set correct parent for lazily created derived inside SvelteDate#18509JaiWey wants to merge 2 commits into
JaiWey wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/94a71ef6535cd0592fc9ce20716944e7dfa6d0ffOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 94a71ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18419
The deriveds inside SvelteDate are created lazily, previously the
parenteffect property could possibly be a to-destory branch effect, which makes the derived shared between multiple components inert after the branch is destroyed. So similar to the#reaction, add an#effectproperty to save, set and restore the correct effect inside SvelteDate.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint