fix: avoid forward the transition property inside EffectNodes in HMR#18498
Open
JaiWey wants to merge 2 commits into
Open
fix: avoid forward the transition property inside EffectNodes in HMR#18498JaiWey wants to merge 2 commits into
JaiWey wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/3894cba2cbc339c935a0a16942ea509d16a66dddOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 3894cba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| /** @type {Effect} */ (active_effect).nodes = effect.nodes; | ||
| if (effect.nodes) { | ||
| // only forward the start and end node | ||
| assign_nodes(effect.nodes.start, effect.nodes.end); |
Contributor
There was a problem hiding this comment.
HMR node forwarding via assign_nodes only runs on first render, leaving the persistent block effect's start/end pointing at destroyed DOM after a component hot-update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18440
Forward the the whole effect.nodes in HMR makes the onoutroend transition events fired twice.
I think only the start and end nodes matter here for the boundary tracking, so instead of forward the whole EffectNode, use the
assign_nodesmethod.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint