fix: prevent selectedcontent mutation from changing the selected option#18495
Open
paoloricciuti wants to merge 2 commits into
Open
fix: prevent selectedcontent mutation from changing the selected option#18495paoloricciuti wants to merge 2 commits into
selectedcontent mutation from changing the selected option#18495paoloricciuti wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/0bdf924aeea751b3cc80d881de403169eba8604cOpen in |
🦋 Changeset detectedLatest commit: 0bdf924 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Ziiyodullayevv
left a comment
There was a problem hiding this comment.
Nice fix for the selectedcontent mutation issue in Svelte. The changes:
- The is_selectedcontent_mutation helper function is well-documented
- Filtering out selectedcontent mutations prevents unnecessary re-renders
- The changeset file follows the project conventions
The root cause analysis in the comment is excellent - explaining why these mutations could revert user-initiated changes. This is a subtle but important fix for select bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday, I've closed #18347 because the issue was 1Password...but @Mystler actually provided a reproduction of a similar issue that could happen with
selectedcontent.Basically, in a situation like this
what happens is that the
oninputis delegated and so it registers the global listener (which means it listen on everyoninputnot just the one from the input). When the select change, theinputevent is dispatched first, the listener runs, doesn't find an__inputhandler and returns. Now before thechangeevent is emitted, theMutationObserverininit_selectis triggered by the browser updatingselectedcontentand invokesselect_optionwithselect.__value. However, since thechangeevent has yet to fire,select.__valuestill has the old value, so we "reselect" that. When the change event runs, the selected option is effectively the old one and the whole thing breaks.I had to add the test in
runtime-browserbecause JSDom doesn't supportselectedcontent