fix: render input default values in SSR#18483
Closed
mturac wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: e00a589 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lintFixes #18446.
This makes SSR serialize
inputdefaultValue/defaultCheckedasvalue/checked, matching the initial DOM state users get after hydration. Explicitvalue/checkedstill wins when it is non-nullish, includingchecked={false}.Test plan:
pnpm test runtime-runes -t input-default-value-ssrpnpm test runtime-runes -t "form-default-value"pnpm testpnpm lintpnpm checkI also temporarily reverted the implementation while keeping the new regression sample;
pnpm test runtime-runes -t input-default-value-ssrfailed in both SSR variants, then passed again after restoring the fix.