Skip to content

breaking: use parseArgs from Node 18.3+ instead of sade/mri#2814

Open
aewing wants to merge 5 commits into
sveltejs:masterfrom
aewing:feat/use-node-parseargs
Open

breaking: use parseArgs from Node 18.3+ instead of sade/mri#2814
aewing wants to merge 5 commits into
sveltejs:masterfrom
aewing:feat/use-node-parseargs

Conversation

@aewing

@aewing aewing commented Aug 6, 2025

Copy link
Copy Markdown
Contributor
  • Replace sade dependency with Node.js built-in parseArgs from node:util
  • Update engines requirement to Node.js >= 18.3.0 (when parseArgs was added)
  • Remove sade and @types/sade dependencies
  • Implement custom help and version handling to match original behavior
  • Add proper TypeScript types for parseArgs options

Resolves #2521

aewing added 3 commits August 6, 2025 16:16
- Replace sade dependency with Node.js built-in parseArgs from node:util
- Update engines requirement to Node.js >= 18.3.0 (when parseArgs was added)
- Remove sade and @types/sade dependencies
- Implement custom help and version handling to match original behavior
- Add proper TypeScript types for parseArgs options

Resolves sveltejs#2521
@aewing
aewing marked this pull request as ready for review August 6, 2025 23:23
@aewing

aewing commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

@benmccann @jasonlyu123 let me know if you had something else in mind, happy to address any feedback.

@dummdidumm

Copy link
Copy Markdown
Member

Looks good, but we should only merge this once we cut a new svelte-check release. Putting it into draft mode to prevent accidental merges. Thank you!

@dummdidumm
dummdidumm marked this pull request as draft August 14, 2025 08:41
@changeset-bot

changeset-bot Bot commented Dec 19, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 37a0a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aewing

aewing commented Dec 19, 2025

Copy link
Copy Markdown
Contributor Author

@dummdidumm any thoughts on this one now? worth keeping/merging, or any rework or reconsideration you'd like here?

@aewing
aewing marked this pull request as ready for review December 19, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

breaking: use parseArgs from Node 18.3

2 participants