Skip to content

fix: rerun load functions when the number of values of a tracked search parameter changes#16495

Open
Nic-Polumeyv wants to merge 1 commit into
sveltejs:version-3from
Nic-Polumeyv:search-params-multiplicity
Open

fix: rerun load functions when the number of values of a tracked search parameter changes#16495
Nic-Polumeyv wants to merge 1 commit into
sveltejs:version-3from
Nic-Polumeyv:search-params-multiplicity

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

Since #11258, diff_search_params compares each key's values as a set, so navigating from ?x=a&x=a to ?x=a is treated as unchanged and load functions tracking x don't rerun. Comparing the sorted value lists instead catches count changes, still treats reordering as unchanged, and is O(V log V) rather than O(V²).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 2.0 (major releases only that fix regressions)

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from b1c5b99:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b1c5b9918c1d91aea3a293283c573ba656252d46

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16495

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b1c5b99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant