fix: rerun load functions when the number of values of a tracked search parameter changes#16495
Open
Nic-Polumeyv wants to merge 1 commit into
Open
fix: rerun load functions when the number of values of a tracked search parameter changes#16495Nic-Polumeyv wants to merge 1 commit into
Nic-Polumeyv wants to merge 1 commit into
Conversation
…ch parameter changes
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b1c5b9918c1d91aea3a293283c573ba656252d46Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: b1c5b99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #11258,
diff_search_paramscompares each key's values as a set, so navigating from?x=a&x=ato?x=ais treated as unchanged and load functions trackingxdon't rerun. Comparing the sorted value lists instead catches count changes, still treats reordering as unchanged, and is O(V log V) rather than O(V²).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 2.0 (major releases only that fix regressions)Edits