Skip to content

perf: use a Set to check element ids when validating fragment links #16494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teemingc merged 1 commit into from
Jul 25, 2026
+8 −3
Merged

perf: use a Set to check element ids when validating fragment links #16494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-pandas-brake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

perf: use a `Set` to check element ids when validating fragment links during prerendering
6 changes: 3 additions & 3 deletions packages/kit/src/core/postbuild/prerender.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env, vit
/** @type {Map<string, Set<string>>} */
const expected_hashlinks = new Map();

/** @type {Map<string, string[]>} */
/** @type {Map<string, Set<string>>} */
const actual_hashlinks = new Map();

/**
Expand Down Expand Up @@ -394,7 +394,7 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env, vit
handle_invalid_url({ href, referrer: decoded });
}

actual_hashlinks.set(decoded, ids);
actual_hashlinks.set(decoded, new Set(ids));

/** @param {string} href */
const removePrerenderOrigin = (href) => {
Expand Down Expand Up @@ -646,7 +646,7 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env, vit
// ignore fragment links to pages that were not prerendered
if (!hashlinks) continue;

if (!hashlinks.includes(id) && !SPECIAL_HASHLINKS.has(id)) {
if (!hashlinks.has(id) && !SPECIAL_HASHLINKS.has(id)) {
handle_missing_id({ id, path, referrers: Array.from(referrers) });
}
}
Expand Down
Loading