Skip to content

perf: avoid quadratic remote form issue merging #16493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nic-Polumeyv wants to merge 2 commits into
base: version-3
Choose a base branch
from
+16 −5
Open

perf: avoid quadratic remote form issue merging #16493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1462ae9
perf: avoid quadratic remote form issue merging
Nic-Polumeyv Jul 23, 2026
986b3e6
chore: annotate position map
Nic-Polumeyv Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-forms-merge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

perf: avoid quadratic remote form issue merging
16 changes: 11 additions & 5 deletions packages/kit/src/runtime/client/remote-functions/form.svelte.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,22 @@ import {
* @returns {InternalRemoteFormIssue[]}
*/
function merge_with_server_issues(form_data, current_issues, client_issues) {
const client_names = new Set(client_issues.map((issue) => issue.name));

const merged = [
...current_issues.filter(
(issue) => issue.server && !client_issues.some((i) => i.name === issue.name)
),
...current_issues.filter((issue) => issue.server && !client_names.has(issue.name)),
...client_issues
];

const keys = Array.from(form_data.keys());
/** @type {Map<string, number>} */
const positions = new Map();
let i = 0;
for (const key of form_data.keys()) {
if (!positions.has(key)) positions.set(key, i);
i++;
}

return merged.sort((a, b) => keys.indexOf(a.name) - keys.indexOf(b.name));
return merged.sort((a, b) => (positions.get(a.name) ?? -1) - (positions.get(b.name) ?? -1));
}

/**
Expand Down
Loading