fix: require a @sveltejs/kit peer dependency for remote modules in node_modules#16492
Open
Nic-Polumeyv wants to merge 3 commits into
Open
fix: require a @sveltejs/kit peer dependency for remote modules in node_modules#16492Nic-Polumeyv wants to merge 3 commits into
Nic-Polumeyv wants to merge 3 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/15bfcd10719e2182d545715683e1f64064725657Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 15bfcd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16473 by implementing the rule from #16473 (comment). Files in node_modules are only treated as remote modules when the package they belong to lists
@sveltejs/kitin itspeerDependencies; files outside node_modules behave as before.The check walks up from the file to the owning
package.json, pastdist/package.jsontype stubs and stopping at the node_modules boundary, so pnpm virtual-store paths and scoped packages resolve correctly. Results are cached per directory. It gates the remote transform, the dev prebundle externalization from #16426, and the dev watcher. The chain check that picks the "enable remoteFunctions" error message still uses the raw pattern, because the import graph there holds root-relative ids that can't be reliably resolved to a package.Reproducing the issue requires the dependency to be processed by Vite, so the new fixture package has a
sveltefield, which makes vite-plugin-svelte mark itssr.noExternallike the reporter's@auth/sveltekitchain; a plain server-external package never reaches the transform. Without the fix, the async test app build fails with the exact error from the issue. The existinge2e-test-dep-remotefixture now declares the peer dependency, which keeps its test passing and covers the other side of the rule.