Skip to content

fix: refetch queries after a redirect when the cached query survives the navigation#16453

Open
Nic-Polumeyv wants to merge 3 commits into
sveltejs:mainfrom
Nic-Polumeyv:fix-remote-query-reset-lost
Open

fix: refetch queries after a redirect when the cached query survives the navigation#16453
Nic-Polumeyv wants to merge 3 commits into
sveltejs:mainfrom
Nic-Polumeyv:fix-remote-query-reset-lost

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #16444, a regression from #16014 (2.65.1). Root cause analysis is in #16444 (comment).

This moves reset validity into a plain non-reactive field, where batch snapshotting can't hide it. reset() sets a plain #stale flag, #get_promise re-runs the query when the promise it sees is stale or missing, and installing any new promise clears the flag. The ??= write-back goes away with it. On the issue's repro Firefox goes from stale on every submit to correct on every submit, with exactly one refetch per redirect in both engines.

The regression test reproduces the race deterministically in the client unit suite, so it doesn't depend on Firefox. A mounted harness with a persistent layout boundary and a conditionally rendered page boundary, and a gated fetch that keeps the reset batch pending while the page re-renders from a separate batch. It fails on main (the page never refetches) and passes with the fix. Two supporting changes, the client vitest project resolves the browser condition so specs can mount components, and *.spec.svelte fixtures are excluded from the published package.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 21, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from fa645e9:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/fa645e9dd2dda34adda8e5efdd50b9a2ee61e019

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16453

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fa645e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant