Skip to content

chore: fix CI on main#16438

Open
Nic-Polumeyv wants to merge 3 commits into
sveltejs:mainfrom
Nic-Polumeyv:fix-main-ci
Open

chore: fix CI on main#16438
Nic-Polumeyv wants to merge 3 commits into
sveltejs:mainfrom
Nic-Polumeyv:fix-main-ci

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

main has been red since #16378 landed on the 17th. Two separate failures in lint-all.

pnpm run check fails because the EnvVarConfig import in src/exports/env/index.js is only referenced from a @template constraint, and tsc doesn't count that as usage:

src/exports/env/index.js(1,5): error TS6133: 'EnvVarConfig' is declared but its value is never read.

Inlining the import is what src/exports/params.js already does for the same shape.

The prepublishOnly diff check fails because the committed types/index.d.ts lost its trailing whitespace and its final newline when it was regenerated in #16417, so the generator reports a diff on every run. Regenerating restores them. That file isn't prettier-covered, so nothing strips them again on its own.

All three lint-all steps pass on this branch. The second and third both fail on main at 08cfba0.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

tsc doesn't count a `@template` constraint as usage of a JSDoc `@import`,
so the import was reported as unused and `pnpm run check` failed.
The committed declarations had trailing whitespace stripped and the final
newline removed, so the regenerate-and-compare CI step failed on every run.
@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 20, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from d0c387b:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d0c387b2a1347123c75962bfac285b1fa8872789

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16438

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d0c387b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant