chore: fix CI on main#16438
Open
Nic-Polumeyv wants to merge 3 commits into
Open
Conversation
tsc doesn't count a `@template` constraint as usage of a JSDoc `@import`, so the import was reported as unused and `pnpm run check` failed.
The committed declarations had trailing whitespace stripped and the final newline removed, so the regenerate-and-compare CI step failed on every run.
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d0c387b2a1347123c75962bfac285b1fa8872789Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red since #16378 landed on the 17th. Two separate failures inlint-all.pnpm run checkfails because theEnvVarConfigimport insrc/exports/env/index.jsis only referenced from a@templateconstraint, and tsc doesn't count that as usage:Inlining the import is what
src/exports/params.jsalready does for the same shape.The
prepublishOnlydiff check fails because the committedtypes/index.d.tslost its trailing whitespace and its final newline when it was regenerated in #16417, so the generator reports a diff on every run. Regenerating restores them. That file isn't prettier-covered, so nothing strips them again on its own.All three
lint-allsteps pass on this branch. The second and third both fail onmainat 08cfba0.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits