Skip to content

chore: fix Renovate parsing of pnpm-workspace.yaml#16404

Merged
Rich-Harris merged 1 commit into
sveltejs:version-3from
Nic-Polumeyv:fix-renovate-workspace-parse
Jul 18, 2026
Merged

chore: fix Renovate parsing of pnpm-workspace.yaml#16404
Rich-Harris merged 1 commit into
sveltejs:version-3from
Nic-Polumeyv:fix-renovate-workspace-parse

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

pnpm-workspace.yaml ends with an overrides key holding only comments, which YAML parses as null. pnpm ignores that, but Renovate's schema rejects it ("expected record, received null") and discards the whole file, so the catalog: entries are invisible to it. That is the "Failed to parse pnpm-workspace.yaml file" warning in #3256, and the reason catalog deps stopped getting update PRs after #15597 in March. {} passes the schema (verified against schema.ts#L53-L67), and the CI yq step overwrites the key either way.

After this merges the non-major group also needs its "recreate" checkbox ticked on #3256, since Renovate suppresses the group while #16180 stays closed.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 88cdf33:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/88cdf33c8bf64f24967a940e59a698fdcc4d6343

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16404

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88cdf33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@Rich-Harris
Rich-Harris merged commit f7a8227 into sveltejs:version-3 Jul 18, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants