fix: ensure CSS URL references are absolute when paths.relative is false#16327
Closed
Nic-Polumeyv wants to merge 1 commit into
Closed
fix: ensure CSS URL references are absolute when paths.relative is false#16327Nic-Polumeyv wants to merge 1 commit into
paths.relative is false#16327Nic-Polumeyv wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/bea8c22f7488db0c0afe03237e1e04c47736a11cOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: bea8c22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Member
|
Duplicate of #16315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
paths.relativeisfalse, the hook that rewrites asset URLs inside emitted CSS still made them relative to the stylesheet, so they no longer resolved against the configured base. The rewrite now bails whenpaths.relativeisfalseand the URLs stay absolute. The options test app gained aPATHS_RELATIVEknob and the paths suite now covers both settings.Split out of #16307.