Skip to content

chore: cleanup vite/index.js#16299

Merged
teemingc merged 2 commits into
version-3from
vite-cleanup
Jul 9, 2026
Merged

chore: cleanup vite/index.js#16299
teemingc merged 2 commits into
version-3from
vite-cleanup

Conversation

@teemingc

@teemingc teemingc commented Jul 9, 2026

Copy link
Copy Markdown
Member

more cleanup separated from #15574

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 31912d1:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/31912d1861d73fe66b5ff70b08fec8600a79d427

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16299

@changeset-bot

changeset-bot Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 31912d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

teemingc
teemingc commented Jul 9, 2026
View reviewed changes
Comment thread packages/kit/src/exports/vite/index.js
await builder.build(builder.environments.ssr)
);

const verbose = vite_config.logLevel === 'info';

@teemingc teemingc Jul 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the same but vite_config is what we store when the configResolved hook runs whereas builder.config is from when the buildApp hook runs much later

@svelte-docs-bot

svelte-docs-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-16299-svelte.vercel.app/

@teemingc teemingc changed the title chore: jsdoc import statements chore: cleanup vite/index.js Jul 9, 2026
@teemingc
teemingc merged commit 8a0504b into version-3 Jul 9, 2026
18 checks passed
@teemingc
teemingc deleted the vite-cleanup branch July 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teemingc @elliott-with-the-longest-name-on-github