Skip to content

chore: minimizeDiff follow-ups (size cap, trailing commas, snapshots)#1164

Merged
manuel3108 merged 3 commits into
chore/improve-minimizeDifffrom
chore/improve-minimizeDiff-v2
Jul 7, 2026
Merged

chore: minimizeDiff follow-ups (size cap, trailing commas, snapshots)#1164
manuel3108 merged 3 commits into
chore/improve-minimizeDifffrom
chore/improve-minimizeDiff-v2

Conversation

@jycouet

@jycouet jycouet commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Follow-ups on top of #1163:

  • re-add the 512KB size cap: diffLines is O(N·D), a ~800KB heavily reformatted file hangs for minutes without it (2ms with it)
  • strip trailing commas before ) in normalizeForComparison so prettier trailingComma: "all" rewraps are restored as formatting-only
  • trim comments, update the 3 failing migrate snapshots (blank-line only diffs)

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 7, 2026

Copy link
Copy Markdown

Install the latest version of sv from d94684c:

pnpm add https://pkg.svelte.dev/sv/c/d94684c580e4cc77325444f2a773ea07153c13b6

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1164

@changeset-bot

changeset-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d94684c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@manuel3108 manuel3108 merged commit 997cba2 into chore/improve-minimizeDiff Jul 7, 2026
6 checks passed
@manuel3108 manuel3108 deleted the chore/improve-minimizeDiff-v2 branch July 7, 2026 20:35
manuel3108 added a commit that referenced this pull request Jul 8, 2026
* stuff

* more stuff

* removed

* improved formatting

* chore: minimizeDiff follow-ups (size cap, trailing commas, snapshots) (#1164)

* re-add diffLines size cap, handle trailing commas before ), trim comments

* update migrate snapshots for new minimizeDiff blank-line behavior

* update cli create snapshots for new minimizeDiff blank-line behavior

---------

Co-authored-by: jyc.dev <jycouet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants