Skip to content

ST-13538 FIX enforce limited decimal places in moneyinput component#223

Open
koyomdev21 wants to merge 4 commits into
masterfrom
ST-13538/fix/optimize-moneyinput-component
Open

ST-13538 FIX enforce limited decimal places in moneyinput component#223
koyomdev21 wants to merge 4 commits into
masterfrom
ST-13538/fix/optimize-moneyinput-component

Conversation

@koyomdev21

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9aba409-84fc-47a7-8ab2-61b4658481ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ST-13538/fix/optimize-moneyinput-component

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@supplycart-bot supplycart-bot changed the title ST-13538 fix optimize rounding in moneyinput component ST-13538 FIX optimize rounding in moneyinput component Jun 5, 2026
@supplycart-bot supplycart-bot enabled auto-merge (squash) June 5, 2026 06:14
@koyomdev21 koyomdev21 requested review from a team June 5, 2026 06:14
@koyomdev21 koyomdev21 changed the title ST-13538 FIX optimize rounding in moneyinput component ST-13538 FIX enforce limited decimal places in moneyinput component Jun 5, 2026
zkri
zkri previously approved these changes Jun 5, 2026
Comment thread src/currency/components/MoneyInputV2Base.vue Outdated
@koyomdev21 koyomdev21 dismissed stale reviews from yuzrie-supplycart and zkri via a6ebb29 June 5, 2026 08:29
xcrone
xcrone previously approved these changes Jun 5, 2026
@koyomdev21 koyomdev21 dismissed stale reviews from xcrone and yuzrie-supplycart via 5510fd3 June 5, 2026 08:47
Comment on lines +39 to +48
/**
* If this is passed as true, it will limit the decimal places
* of the input to the `decimal` prop value. This is useful
* for cases like weight or quantity inputs where you want to
* enforce a certain number of decimal places.
*/
isEnforceLimitedUnit: {
type: Boolean,
default: false,
},

@Ima-Acikima Ima-Acikima Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can explain how this is different from the usage of existing prop decimal. and why the comment has weight and quantity, because this component should be used strictly for money input only, weight and quantity can use QuantityInput

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants