Skip to content

Fix auction taker list row selection#112

Draft
KeeganEad wants to merge 1 commit into
superrare:mainfrom
KeeganEad:keegan/clawpatch-auction-taker-rows
Draft

Fix auction taker list row selection#112
KeeganEad wants to merge 1 commit into
superrare:mainfrom
KeeganEad:keegan/clawpatch-auction-taker-rows

Conversation

@KeeganEad

Copy link
Copy Markdown
Contributor

Finding

  • Clawpatch: fnd_sig-feat-cli-command-88fa9c11ee-_5f83fe793c
  • Title: Auction taker list drops non-winning bids from results

Assessment

The finding is real and patch-level. rare auction list --side taker advertises bidder mode and sends auctionBidderAddress to the search API, but the renderer then filtered returned auctions down to only those where the account was the current highest bidder. That could hide auctions where the account had bid and was later outbid, even though the API result matched the requested bidder query.

This does not require a public API break. The fix only changes CLI row selection and exposes a command-local pure helper for tests.

Fix

  • Keep maker auction row filtering by sellerAddress.
  • Trust the API result set for taker auction rows instead of applying a highest-bidder-only filter.
  • Add unit coverage for an outbid taker row and maker filtering.
  • Clean up existing viem receipt test fixtures so tsconfig.test.json passes.

Validation

  • clawpatch revalidate --finding fnd_sig-feat-cli-command-88fa9c11ee-_5f83fe793c --plain -> fixed
  • npx vitest run test/unit/commands/account-market-list.test.ts --config vitest.config.ts
  • npm run typecheck
  • npm run test:typecheck
  • npm run lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant