Fix auction taker list row selection#112
Draft
KeeganEad wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
fnd_sig-feat-cli-command-88fa9c11ee-_5f83fe793cAssessment
The finding is real and patch-level.
rare auction list --side takeradvertises bidder mode and sendsauctionBidderAddressto the search API, but the renderer then filtered returned auctions down to only those where the account was the current highest bidder. That could hide auctions where the account had bid and was later outbid, even though the API result matched the requested bidder query.This does not require a public API break. The fix only changes CLI row selection and exposes a command-local pure helper for tests.
Fix
sellerAddress.tsconfig.test.jsonpasses.Validation
clawpatch revalidate --finding fnd_sig-feat-cli-command-88fa9c11ee-_5f83fe793c --plain-> fixednpx vitest run test/unit/commands/account-market-list.test.ts --config vitest.config.tsnpm run typechecknpm run test:typechecknpm run lint