Skip to content

Fix dark theme gradient for expand button on long Hadith#125

Open
rana-shoaib wants to merge 1 commit into
sunnah-com:masterfrom
rana-shoaib:master
Open

Fix dark theme gradient for expand button on long Hadith#125
rana-shoaib wants to merge 1 commit into
sunnah-com:masterfrom
rana-shoaib:master

Conversation

@rana-shoaib

Copy link
Copy Markdown
Contributor

Resolved an issue where the 'expand more content' button for long Hadith was missing the dark theme gradient, ensuring consistent styling.

@ahadith

ahadith commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Jazakallahu khayr!

Could we trouble you to take care of a couple more minor issues that arose with the dark mode?

  1. I think there's a better color out there for the permalink text
    Screenshot from 2024-10-06 17-53-34
    (specifically, the "Sahih al-Bukhari 2" link). If you could do a bit of research on usability websites to find the best color, that would be great

  2. The header in the search results is too bright.
    signal-2024-10-07-112210_002

@ahadith

ahadith commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Also let us know if there's a way to reach you over email/Signal.

@rana-shoaib

Copy link
Copy Markdown
Contributor Author

Also let us know if there's a way to reach you over email/Signal.
ranashoaibg073@gmail.com

@Yugi-2

Yugi-2 commented Oct 13, 2024

Copy link
Copy Markdown
Collaborator

Jazakallahu khayr!

Could we trouble you to take care of a couple more minor issues that arose with the dark mode?

1. I think there's a better color out there for the permalink text
   ![Screenshot from 2024-10-06 17-53-34](https://private-user-images.githubusercontent.com/22137719/374363294-66ff62c3-56e8-443e-aec6-d4b21b45eb5f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjg4NDY4MDAsIm5iZiI6MTcyODg0NjUwMCwicGF0aCI6Ii8yMjEzNzcxOS8zNzQzNjMyOTQtNjZmZjYyYzMtNTZlOC00NDNlLWFlYzYtZDRiMjFiNDVlYjVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDEzVDE5MDgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3ZWRlMDRhODJjYjkxODBjNjMzZWY2YmZjODg1YTdmZTdjZWMxYzU4ZDNiYmRmY2M2YTdhNjA0MGEwYjRkMDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.O0tMZ6QgCOZGoyXzGEEB7PyYA1qHDLP0b-T1WiGhvkc)
   (specifically, the "Sahih al-Bukhari 2" link). If you could do a bit of research on usability websites to find the best color, that would be great

2. The header in the search results is too bright.
   ![signal-2024-10-07-112210_002](https://private-user-images.githubusercontent.com/22137719/374363445-68e28012-c9bf-406b-a784-4b3c765529c7.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjg4NDY4MDAsIm5iZiI6MTcyODg0NjUwMCwicGF0aCI6Ii8yMjEzNzcxOS8zNzQzNjM0NDUtNjhlMjgwMTItYzliZi00MDZiLWE3ODQtNGIzYzc2NTUyOWM3LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDEzVDE5MDgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlNGNmMjdlMjgwNzRjMmEzZGVkNTBlNGJkNGM4NDNlYzk4MmEwN2ZmNGU5OTE1ZmRiMjM2Mjc5ODFkY2EyNGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SmLcQC93lAedVnX5G2LPzHkp_UDEE1_45tyoQuk1LjU)

@rana-shoaib Can you address these two concerns in this PR as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants