Fix Google Sign-In deserialization crash on desktop targets under ProGuard (#16)#17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16
Cause of the Crash
When packaging a Compose Multiplatform desktop application for distribution (e.g., as
.msi,.dmg, or.deb), ProGuard runs by default on the JVM target to shrink the bundle size and optimize code.In
GoogleAuthManagerJvm, the library was using Gson to deserialize the Google user info JSON response into a private nested data class:GoogleAuthManagerJvm.GoogleUser. Since Gson relies on runtime reflection, it fails in a shrunken/obfuscated environment because ProGuard strips/renames the fields and constructors of private classes, leading to the reportedRuntimeException.Solution
GoogleUserclass and reused the shared@SerializableGoogleUserdata class fromcommonMain.kotlinx.serializationuses compile-time generated serializers rather than runtime JVM reflection, it is fully compatible with ProGuard/R8 out of the box.0.3.8.