You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
UPDATE: Looking at alexcrichton/dlmalloc-rs vs sunfishcode/rustix-dlmalloc history, it seems you're maintaining the fork for rustix support by rewriting history with a rebase to sync for updates? I'll raise this PR upstream at alexcrichton/dlmalloc-rs instead then 👍 (EDIT:Done)
The reference doesn't quite communicate the context for usage here in this crate? I assume it's related to building the std lib with nightly? The comment might benefit from a little more context regarding that but I doubt most readers care (if they don't grok the provided context)? 😅
[dependencies]
# ...
# Internal feature, only used when building as part of libstd, not part of the
# stable interface of this crate.
core = { version = '1.0.0', optional = true, package = 'rustc-std-workspace-core' }
alloc = { version = '1.0.0', optional = true, package = 'rustc-std-workspace-alloc' }
[features]
# ...
# Internal feature, only used when building as part of libstd, not part of the
# stable interface of this crate.
rustc-dep-of-std = ['core', 'alloc', 'gimli/rustc-dep-of-std']
That same Nov 2018 commit shows that the cfg-if dep is unrelated to other two deps for supporting rustc-dep-of-std, so it shouldn't be grouped contextually with those 😓
cfg-if was added here (commit from March 2022) and PR in Jan 2024 at alexcrichton/dlmalloc-rs (prior to forking into sunfishcode/rustix-dlmalloc).
Looking at some projects that dropped it, I didn't see any change to a rust-version field in Cargo.toml, so AFAIU this is only relevant to nightly? (unless at some point the ability to build libstd becomes stable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE: Looking at
alexcrichton/dlmalloc-rsvssunfishcode/rustix-dlmallochistory, it seems you're maintaining the fork for rustix support by rewriting history with a rebase to sync for updates? I'll raise this PR upstream atalexcrichton/dlmalloc-rsinstead then 👍 (EDIT: Done)This appears to have changed in 2020 with Rust 1.47.
The reference doesn't quite communicate the context for usage here in this crate? I assume it's related to building the std lib with nightly? The comment might benefit from a little more context regarding that but I doubt most readers care (if they don't grok the provided context)? 😅