Skip to content

cannot overwrite directory - #4

Open
zhaoc1 wants to merge 1 commit into
sunbeam-labs:masterfrom
zhaoc1:oneline
Open

cannot overwrite directory#4
zhaoc1 wants to merge 1 commit into
sunbeam-labs:masterfrom
zhaoc1:oneline

Conversation

@zhaoc1

@zhaoc1 zhaoc1 commented Aug 17, 2018

Copy link
Copy Markdown
Member

No description provided.

@ressy

ressy commented Aug 18, 2018

Copy link
Copy Markdown
Member

Ooh good point. But without the -T and if the directory already exists it'll just put a symlink inside that directory which won't do the right thing either. If we want to support an existing environment created by this extension before these recent changes, we'll have to detect the directory, remove it, and then symlink. Maybe something like [[ -d "$DIR" && ! -h "$DIR" ]] && mv "$DIR" "$DIR_old", for "$CONDA_PREFIX"/bin/databases and "$CONDA_PREFIX"/bin/databases_metaphlan? What do you think?

@ressy

ressy commented Aug 18, 2018

Copy link
Copy Markdown
Member

On the other hand, none if it should matter for newly-created environments... so if you remove the directory in sunbeam_output/.snakemake/conda/ an let the extension recreate it, I think it should symlink to your sunbeam environment properly either way.

@ressy

ressy commented Jul 10, 2019

Copy link
Copy Markdown
Member

This might become a moot issue if we switch to a separately-managed database as @scottdaniel described in #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants