PhoneNumberInput flag size#3743
Open
sirineJ wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 07ae186 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3743 +/- ##
==========================================
- Coverage 93.40% 93.35% -0.05%
==========================================
Files 197 197
Lines 4334 4336 +2
Branches 1745 1749 +4
==========================================
Hits 4048 4048
- Misses 259 261 +2
Partials 27 27
🚀 New features to boost your workflow:
|
missating
reviewed
Jul 3, 2026
| countryCode.ref as ForwardedRef<HTMLSelectElement>, | ||
| )} | ||
| renderPrefix={countryCode.renderPrefix ?? DefaultPrefix} | ||
| renderPrefix={countryCode.renderPrefix ?? getDefaultPrefix(size)} |
Contributor
There was a problem hiding this comment.
Should getDefaultPrefix(size) be memoized so it doesn't end up creating a new reference on every render?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-1762
Purpose
#3711 introduced the
sizeprop in the Flag component. Since we also recently support sizes in input fields, we can make the flag size in the PhoneNumberInput component responsive to the input's size.Approach and changes
Use PhoneNumberInput's size to adjust default prefix flag size accordingly.
Definition of done