Change icon sizes token to rem units#3741
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 105b70b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Size Change: +136 B (+0.02%) Total Size: 835 kB 📦 View Changed
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3741 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 201 201
Lines 4562 4562
Branches 1785 1785
=======================================
Hits 4266 4266
Misses 267 267
Partials 29 29
🚀 New features to boost your workflow:
|
missating
changed the title
missating
changed the title
connor-baer
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-1691
Purpose
This deprecates the existing -
-cui-icon-sizes-kilo/mega/giga/teratokens and introduces replacements usingrem units and t-shirt size names. The deprecated tokens retain their originalpxvalues; no consumers are broken.Approach and changes
Added four new tokens to
@sumup-oss/design-tokens:The T-shirt sizes align with the
sizeprops already used across other components (Button, Spinner, Flag, etc.). Thes/m/l/xlscale reflects how16pxis the explicits (small)size.Definition of done