feat(circuit-ui): InlineNotification promo variant#3649
Closed
matoous wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: ab4c0fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
matoous
force-pushed
the
md/notification-inline-promo-variant
branch
from
5a290c9 to
f113484
Compare
matoous
force-pushed
the
md/notification-inline-promo-variant
branch
from
f113484 to
4c721af
Compare
Add `promo` variant for `InlineNotification`. It uses our existing brand tokens. The use-case in mind is the developer portal build on top of Starlight (Astro) where we use the `Aside` component from Starlight which I would like to replace with `NotificationInline` but in a few places we use the promo variant which isn't available in circuit-ui.
matoous
force-pushed
the
md/notification-inline-promo-variant
branch
from
4c721af to
ab4c0fa
Compare
Contributor
|
Size Change: +52 B (+0.01%) Total Size: 833 kB 📦 View Changed
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3649 +/- ##
==========================================
+ Coverage 93.48% 93.52% +0.04%
==========================================
Files 201 201
Lines 4540 4540
Branches 1780 1780
==========================================
+ Hits 4244 4246 +2
+ Misses 267 265 -2
Partials 29 29
🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing in favor of: #3733 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs
Promoteicon in size16.Add
promovariant forInlineNotification. It uses our existing brand tokens. The use-case in mind is the developer portal build on top of Starlight (Astro) where we use theAsidecomponent from Starlight which I would like to replace withNotificationInlinebut in a few places we use the promo variant which isn't available in circuit-ui.