refactor: merge Cradle type into container.ts, delete types.ts#11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the DI typing setup by moving the Cradle interface into the Awilix container module and deleting the standalone types.ts, keeping DI type definitions co-located with registration.
Changes:
- Deleted
src/server/infrastructure/di/types.ts(previous home of theCradleinterface). - Inlined
Cradleintosrc/server/infrastructure/di/container.tsand replaced the old import. - Adjusted imports and formatting in
container.tsaccordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/server/infrastructure/di/types.ts | Removed now-redundant Cradle type definition file. |
| src/server/infrastructure/di/container.ts | Defines Cradle locally and updates DI container imports/registration formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+4
| import { Redis } from "ioredis"; | ||
| import { db, DB } from "../db"; |
# Conflicts: # src/server/infrastructure/di/container.ts # src/server/infrastructure/di/types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.