Skip to content

🐛(frontend) prevent share modal crash on team-based accesses #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maartendra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛(frontend) prevent share modal crash on team-based accesses #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to

### Fixed

- 🐛(frontend) prevent the share modal from crashing on team-based accesses
- 🐛(frontend) keep uploaded items usable while malware analysis runs
- 🐛(backend) stream export files from S3 without buffering

Expand Down
7 changes: 7 additions & 0 deletions src/frontend/apps/drive/src/features/explorer/components/modals/share/ItemShareModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ export const ItemShareModal = ({
const accessesByUserId = new Map<string, Access>();

data.forEach((access) => {
// Team-based accesses (access.team set, user null) grant a whole team, not a
// single user. This member list is keyed by user id and renders per-user
// rows, so skip them — otherwise `access.user.id` null-derefs and the whole
// modal crashes (a client-side exception).
if (access.team) {
return;
}
const existing = accessesByUserId.get(access.user.id);

if (!existing) {
Expand Down