Skip to content

Added a few new locales in english and french#53

Open
nexepu wants to merge 2 commits into
suggestionsbot:feat/version/3.27from
nexepu:master
Open

Added a few new locales in english and french#53
nexepu wants to merge 2 commits into
suggestionsbot:feat/version/3.27from
nexepu:master

Conversation

@nexepu

@nexepu nexepu commented Jul 14, 2023

Copy link
Copy Markdown

Summary

Checklist

  • Has been manually tested
  • Has unit-tests, if applicable
  • New features have attached cooldowns
  • Any new strings are localized correctly
  • These work on both new and old style suggestions
  • All interactions have been deferred
  • New errors have been updated on stats.suggestions.gg
  • Guild config method names aren't duplicated
  • New localizations have been added

@Skelmis Skelmis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use bot.get_localized_string in place of bot.get_locale

@nexepu

nexepu commented Jul 14, 2023

Copy link
Copy Markdown
Author

Please check the second commit, I have done the requested changes.

@Skelmis Skelmis changed the base branch from master to feat/version/3.19 October 23, 2023 01:58
@acollierr17

acollierr17 commented Dec 19, 2023

Copy link
Copy Markdown
Member

We are looking at getting these strings reviewed within the next week. However, we would like the PR to be reviewed to make sure the strings are updated to the current version of the bot being developed, which is feat/version/3.20.

Since I'm still determining how many strings have been added since this PR was initially opened, I'm bringing up the matter here.

If you have any questions, please let me or @Skelmis know.

Edit: The en_US file, found in newer versions, is to be used as the base file for translations.

@Skelmis Skelmis changed the base branch from feat/version/3.19 to feat/version/3.27 November 3, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants