Skip to content

feat(session): cross-project session list and session lock#403

Open
phanen wants to merge 2 commits into
sudo-tee:mainfrom
phanen:feat/global-session
Open

feat(session): cross-project session list and session lock#403
phanen wants to merge 2 commits into
sudo-tee:mainfrom
phanen:feat/global-session

Conversation

@phanen
Copy link
Copy Markdown
Contributor

@phanen phanen commented Jun 5, 2026

Preserve the active session across DirChanged via a session lock
toggle, and have the session picker list all projects from
/experimental/session when locked (bypassing the api_client's
directory injection).

@phanen phanen force-pushed the feat/global-session branch from cab6b50 to a0c7989 Compare June 5, 2026 13:40
@phanen
Copy link
Copy Markdown
Contributor Author

phanen commented Jun 5, 2026

To elaborate why /experimental/session is used:

Regardless of what the client passes for directory / scope, the server injects ctx.project.id inside listByProject and only queries sessions for that project (see listByProject).

@phanen phanen force-pushed the feat/global-session branch 7 times, most recently from 4374980 to de9e2cb Compare June 5, 2026 16:55
@phanen
Copy link
Copy Markdown
Contributor Author

phanen commented Jun 5, 2026

bd7be98 9d2eda0 improve the format_width as a follow up of #402

cc @hermandavid

@phanen phanen marked this pull request as ready for review June 5, 2026 16:59
@phanen phanen force-pushed the feat/global-session branch from de9e2cb to fa3ecac Compare June 5, 2026 17:04
@hermandavid
Copy link
Copy Markdown
Contributor

Thank you, I replied to the #402.

phanen added 2 commits June 6, 2026 01:16
Preserve the active session across DirChanged via a session lock
toggle, and have the session picker list all projects from
/experimental/session when locked (bypassing the api_client's
directory injection).
@phanen phanen force-pushed the feat/global-session branch from fa3ecac to 04793b3 Compare June 5, 2026 17:16
@phanen
Copy link
Copy Markdown
Contributor Author

phanen commented Jun 5, 2026

Ok, I think the picker layout fix is correct for me now. I also test vanilla config, the behavior is not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants